Merge pull request #636 from google:dependabot/cargo/tempfile-3.20.0 #2434
ci.yml
on: push
doc / nightly
34s
Matrix: clippy
Matrix: integration-test-latest-deps
Matrix: integration-test
Matrix: lint / ubuntu
Matrix: test-latest-deps
Matrix: test-no-default-features
Matrix: test
Annotations
33 warnings
variables can be used directly in the `format!` string:
googletest/tests/colorized_diff_test.rs#L25
warning: variables can be used directly in the `format!` string
--> googletest/tests/colorized_diff_test.rs:25:9
|
25 | write!(&mut text, "\n{}", item).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
|
25 - write!(&mut text, "\n{}", item).unwrap();
25 + write!(&mut text, "\n{item}").unwrap();
|
|
variables can be used directly in the `format!` string:
googletest/tests/no_color_test.rs#L25
warning: variables can be used directly in the `format!` string
--> googletest/tests/no_color_test.rs:25:9
|
25 | write!(&mut text, "\n{}", item).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
|
25 - write!(&mut text, "\n{}", item).unwrap();
25 + write!(&mut text, "\n{item}").unwrap();
|
|
variables can be used directly in the `format!` string:
googletest/src/matchers/eq_matcher.rs#L100
warning: variables can be used directly in the `format!` string
--> googletest/src/matchers/eq_matcher.rs:100:28
|
100 | let actual_debug = format!("{:#?}", actual);
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
100 - let actual_debug = format!("{:#?}", actual);
100 + let actual_debug = format!("{actual:#?}");
|
|
variables can be used directly in the `format!` string:
googletest/src/matchers/display_matcher.rs#L98
warning: variables can be used directly in the `format!` string
--> googletest/src/matchers/display_matcher.rs:98:17
|
98 | write!(f, "{:?}", self)
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
98 - write!(f, "{:?}", self)
98 + write!(f, "{self:?}")
|
|
variables can be used directly in the `format!` string:
googletest/src/matchers/contains_matcher.rs#L109
warning: variables can be used directly in the `format!` string
--> googletest/src/matchers/contains_matcher.rs:109:29
|
109 | (_, Some(_)) => format!("which contains {} matching elements", count).into(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
109 - (_, Some(_)) => format!("which contains {} matching elements", count).into(),
109 + (_, Some(_)) => format!("which contains {count} matching elements").into(),
|
|
variables can be used directly in the `format!` string:
googletest/src/matchers/container_eq_matcher.rs#L247
warning: variables can be used directly in the `format!` string
--> googletest/src/matchers/container_eq_matcher.rs:247:36
|
247 | .map(|element| format!("{:?}", element))
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
247 - .map(|element| format!("{:?}", element))
247 + .map(|element| format!("{element:?}"))
|
|
variables can be used directly in the `format!` string:
googletest/src/matcher_support/summarize_diff.rs#L447
warning: variables can be used directly in the `format!` string
--> googletest/src/matcher_support/summarize_diff.rs:447:13
|
447 | write!(&mut text, "\n{}", item).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
447 - write!(&mut text, "\n{}", item).unwrap();
447 + write!(&mut text, "\n{item}").unwrap();
|
|
variables can be used directly in the `format!` string:
googletest/src/matcher_support/match_matrix.rs#L351
warning: variables can be used directly in the `format!` string
--> googletest/src/matcher_support/match_matrix.rs:351:28
|
351 | .map(|idx| format!("#{}", idx))
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
351 - .map(|idx| format!("#{}", idx))
351 + .map(|idx| format!("#{idx}"))
|
|
variables can be used directly in the `format!` string:
googletest/src/matcher_support/match_matrix.rs#L345
warning: variables can be used directly in the `format!` string
--> googletest/src/matcher_support/match_matrix.rs:345:28
|
345 | .map(|idx| format!("#{}", idx))
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
345 - .map(|idx| format!("#{}", idx))
345 + .map(|idx| format!("#{idx}"))
|
|
variables can be used directly in the `format!` string:
googletest/src/matcher_support/match_matrix.rs#L61
warning: variables can be used directly in the `format!` string
--> googletest/src/matcher_support/match_matrix.rs:61:21
|
61 | format!("which has size {} (expected at most {})", actual_size, expected_size)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
61 - format!("which has size {} (expected at most {})", actual_size, expected_size)
61 + format!("which has size {actual_size} (expected at most {expected_size})")
|
|
variables can be used directly in the `format!` string:
googletest/src/matcher_support/match_matrix.rs#L56
warning: variables can be used directly in the `format!` string
--> googletest/src/matcher_support/match_matrix.rs:56:21
|
56 | format!("which has size {} (expected at least {})", actual_size, expected_size)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
56 - format!("which has size {} (expected at least {})", actual_size, expected_size)
56 + format!("which has size {actual_size} (expected at least {expected_size})")
|
|
variables can be used directly in the `format!` string:
googletest/src/matcher_support/match_matrix.rs#L52
warning: variables can be used directly in the `format!` string
--> googletest/src/matcher_support/match_matrix.rs:52:21
|
52 | format!("which has size {} (expected {})", actual_size, expected_size).into(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
52 - format!("which has size {} (expected {})", actual_size, expected_size).into(),
52 + format!("which has size {actual_size} (expected {expected_size})").into(),
|
|
variables can be used directly in the `format!` string:
googletest/src/internal/test_outcome.rs#L221
warning: variables can be used directly in the `format!` string
--> googletest/src/internal/test_outcome.rs:221:13
|
221 | writeln!(f, "{}", custom_message)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
221 - writeln!(f, "{}", custom_message)?;
221 + writeln!(f, "{custom_message}")?;
|
|
variables can be used directly in the `format!` string:
googletest/src/internal/test_outcome.rs#L213
warning: variables can be used directly in the `format!` string
--> googletest/src/internal/test_outcome.rs:213:9
|
213 | println!("{}", self);
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
213 - println!("{}", self);
213 + println!("{self}");
|
|
variables can be used directly in the `format!` string:
googletest/src/internal/test_outcome.rs#L185
warning: variables can be used directly in the `format!` string
--> googletest/src/internal/test_outcome.rs:185:54
|
185 | Location::Fake { file, line, column } => write!(f, "{}:{}:{}", file, line, column),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
185 - Location::Fake { file, line, column } => write!(f, "{}:{}:{}", file, line, column),
185 + Location::Fake { file, line, column } => write!(f, "{file}:{line}:{column}"),
|
|
variables can be used directly in the `format!` string:
googletest/src/internal/test_outcome.rs#L184
warning: variables can be used directly in the `format!` string
--> googletest/src/internal/test_outcome.rs:184:34
|
184 | Location::Real(l) => write!(f, "{}", l),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
184 - Location::Real(l) => write!(f, "{}", l),
184 + Location::Real(l) => write!(f, "{l}"),
|
|
variables can be used directly in the `format!` string:
googletest/src/internal/description_renderer.rs#L133
warning: variables can be used directly in the `format!` string
--> googletest/src/internal/description_renderer.rs:133:38
|
133 | Decoration::Enumerate => format!("{:>enumeration_padding$}. ", index).into(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
133 - Decoration::Enumerate => format!("{:>enumeration_padding$}. ", index).into(),
133 + Decoration::Enumerate => format!("{index:>enumeration_padding$}. ").into(),
|
|
variables can be used directly in the `format!` string:
googletest/src/fmt.rs#L51
warning: variables can be used directly in the `format!` string
--> googletest/src/fmt.rs:51:13
|
51 | write!(output, "\n {} does not implement Debug,", expr_label)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
|
51 - write!(output, "\n {} does not implement Debug,", expr_label)
51 + write!(output, "\n {expr_label} does not implement Debug,")
|
|
variables can be used directly in the `format!` string:
googletest/tests/colorized_diff_test.rs#L25
warning: variables can be used directly in the `format!` string
--> googletest/tests/colorized_diff_test.rs:25:9
|
25 | write!(&mut text, "\n{}", item).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
|
25 - write!(&mut text, "\n{}", item).unwrap();
25 + write!(&mut text, "\n{item}").unwrap();
|
|
variables can be used directly in the `format!` string:
googletest/src/matchers/eq_matcher.rs#L100
warning: variables can be used directly in the `format!` string
--> googletest/src/matchers/eq_matcher.rs:100:28
|
100 | let actual_debug = format!("{:#?}", actual);
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
100 - let actual_debug = format!("{:#?}", actual);
100 + let actual_debug = format!("{actual:#?}");
|
|
variables can be used directly in the `format!` string:
googletest/src/matchers/contains_matcher.rs#L109
warning: variables can be used directly in the `format!` string
--> googletest/src/matchers/contains_matcher.rs:109:29
|
109 | (_, Some(_)) => format!("which contains {} matching elements", count).into(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
109 - (_, Some(_)) => format!("which contains {} matching elements", count).into(),
109 + (_, Some(_)) => format!("which contains {count} matching elements").into(),
|
|
variables can be used directly in the `format!` string:
googletest/src/matchers/container_eq_matcher.rs#L247
warning: variables can be used directly in the `format!` string
--> googletest/src/matchers/container_eq_matcher.rs:247:36
|
247 | .map(|element| format!("{:?}", element))
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
247 - .map(|element| format!("{:?}", element))
247 + .map(|element| format!("{element:?}"))
|
|
variables can be used directly in the `format!` string:
googletest/src/matcher_support/match_matrix.rs#L351
warning: variables can be used directly in the `format!` string
--> googletest/src/matcher_support/match_matrix.rs:351:28
|
351 | .map(|idx| format!("#{}", idx))
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
351 - .map(|idx| format!("#{}", idx))
351 + .map(|idx| format!("#{idx}"))
|
|
variables can be used directly in the `format!` string:
googletest/src/matcher_support/match_matrix.rs#L345
warning: variables can be used directly in the `format!` string
--> googletest/src/matcher_support/match_matrix.rs:345:28
|
345 | .map(|idx| format!("#{}", idx))
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
345 - .map(|idx| format!("#{}", idx))
345 + .map(|idx| format!("#{idx}"))
|
|
variables can be used directly in the `format!` string:
googletest/src/matcher_support/match_matrix.rs#L61
warning: variables can be used directly in the `format!` string
--> googletest/src/matcher_support/match_matrix.rs:61:21
|
61 | format!("which has size {} (expected at most {})", actual_size, expected_size)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
61 - format!("which has size {} (expected at most {})", actual_size, expected_size)
61 + format!("which has size {actual_size} (expected at most {expected_size})")
|
|
variables can be used directly in the `format!` string:
googletest/src/matcher_support/match_matrix.rs#L56
warning: variables can be used directly in the `format!` string
--> googletest/src/matcher_support/match_matrix.rs:56:21
|
56 | format!("which has size {} (expected at least {})", actual_size, expected_size)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
56 - format!("which has size {} (expected at least {})", actual_size, expected_size)
56 + format!("which has size {actual_size} (expected at least {expected_size})")
|
|
variables can be used directly in the `format!` string:
googletest/src/matcher_support/match_matrix.rs#L52
warning: variables can be used directly in the `format!` string
--> googletest/src/matcher_support/match_matrix.rs:52:21
|
52 | format!("which has size {} (expected {})", actual_size, expected_size).into(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
52 - format!("which has size {} (expected {})", actual_size, expected_size).into(),
52 + format!("which has size {actual_size} (expected {expected_size})").into(),
|
|
variables can be used directly in the `format!` string:
googletest/src/internal/test_outcome.rs#L221
warning: variables can be used directly in the `format!` string
--> googletest/src/internal/test_outcome.rs:221:13
|
221 | writeln!(f, "{}", custom_message)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
221 - writeln!(f, "{}", custom_message)?;
221 + writeln!(f, "{custom_message}")?;
|
|
variables can be used directly in the `format!` string:
googletest/src/internal/test_outcome.rs#L213
warning: variables can be used directly in the `format!` string
--> googletest/src/internal/test_outcome.rs:213:9
|
213 | println!("{}", self);
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
213 - println!("{}", self);
213 + println!("{self}");
|
|
variables can be used directly in the `format!` string:
googletest/src/internal/test_outcome.rs#L185
warning: variables can be used directly in the `format!` string
--> googletest/src/internal/test_outcome.rs:185:54
|
185 | Location::Fake { file, line, column } => write!(f, "{}:{}:{}", file, line, column),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
185 - Location::Fake { file, line, column } => write!(f, "{}:{}:{}", file, line, column),
185 + Location::Fake { file, line, column } => write!(f, "{file}:{line}:{column}"),
|
|
variables can be used directly in the `format!` string:
googletest/src/internal/test_outcome.rs#L184
warning: variables can be used directly in the `format!` string
--> googletest/src/internal/test_outcome.rs:184:34
|
184 | Location::Real(l) => write!(f, "{}", l),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
184 - Location::Real(l) => write!(f, "{}", l),
184 + Location::Real(l) => write!(f, "{l}"),
|
|
variables can be used directly in the `format!` string:
googletest/src/internal/description_renderer.rs#L133
warning: variables can be used directly in the `format!` string
--> googletest/src/internal/description_renderer.rs:133:38
|
133 | Decoration::Enumerate => format!("{:>enumeration_padding$}. ", index).into(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
133 - Decoration::Enumerate => format!("{:>enumeration_padding$}. ", index).into(),
133 + Decoration::Enumerate => format!("{index:>enumeration_padding$}. ").into(),
|
|
variables can be used directly in the `format!` string:
googletest/src/fmt.rs#L51
warning: variables can be used directly in the `format!` string
--> googletest/src/fmt.rs:51:13
|
51 | write!(output, "\n {} does not implement Debug,", expr_label)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
|
51 - write!(output, "\n {} does not implement Debug,", expr_label)
51 + write!(output, "\n {expr_label} does not implement Debug,")
|
|