feat: Go implementation for manifestYamlDoc and escapeStringJson #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theSuess
added a commit
to theSuess/go-jsonnet
that referenced
this pull request
Jun 11, 2024
The `valueToString` operation introduced by google#742 is incompatible with the way the implementation from google#739 as it tries to manifest an object from stack while the implementation needed by the debugger returns the value as-is without further evaluation.
vhata
pushed a commit
to discord/go-jsonnet
that referenced
this pull request
Aug 30, 2024
…gle#742) * Builtins for escapeStringJson and manifestYamlDoc * Benchmark and tests
vhata
pushed a commit
to discord/go-jsonnet
that referenced
this pull request
Aug 30, 2024
The `valueToString` operation introduced by google#742 is incompatible with the way the implementation from google#739 as it tries to manifest an object from stack while the implementation needed by the debugger returns the value as-is without further evaluation.
rudo-thomas
reviewed
Apr 22, 2025
| } else { | ||
| buf.WriteByte(' ') | ||
| } | ||
| aux(fieldValue, buf, cindent) |
There was a problem hiding this comment.
Note that the error from this call is unchecked.
Fix: #800
There was a problem hiding this comment.
This PR (#742) introduces a bug into manifestYamlDoc, which is now part of the 0.21.0 release. (We were even getting stack traces, but that's besides the point here.)
The fix is trivial (#800), but I'm having difficulties getting it merged -- nobody responded...
@jgraeger, can I kindly ask you, as the original author, to help me ping the right people and get the fix merged? Thanks :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces native Go implementations for two standard library functions in Jsonnet: manifestYamlDoc and escapeStringJson. These enhancements are a response to performance challenges, especially noticeable in cases where
quote_keys=falseis set. This issue is documented in google/jsonnet#1019 and also holds for the Go implementation.Benchmarks
On a large, non-public codebase generating megabytes of yaml from jsonnet, the runtime decreased from over 10 minutes to 8 seconds.