-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Manufacturing Consent: Version 3.000; ttfautohint (v1.8.4.7-5d5b) added #9496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Taken from the upstream repo https://github.com/googlefonts/manufacturing-consent-font at commit googlefonts/manufacturing-consent-font@80c3d82. Resolves #2071
Dave asked for a swift processing of the font for a client, so the character support will remain insufficient. I'm assuming this particular author wouldn't care for a bio, so ignoring it. |
FontSpector reportfontspector version: 1.0.2 Checks with FATAL resultsThese must be addressed first. [2] ofl/manufacturingconsent/ManufacturingConsent-Regular.ttf💥 ERROR Version number has increased since previous release on Google Fonts? (googlefonts/version_bump)
💥 ERROR Check if the vertical metrics of a family are similar to the same family hosted on Google Fonts. (googlefonts/vertical_metrics_regressions)
All other checks[20] ofl/manufacturingconsent/ManufacturingConsent-Regular.ttf🔥 FAIL Ensure the font supports case swapping for all its glyphs. (case_mapping)
🔥 FAIL Shapes languages in all GF glyphsets. (googlefonts/glyphsets/shape_languages)
|
ManufacturingConsent-Regular.ttf | |
---|---|
Dehinted Size | 57668 |
Hinted Size | 61796 |
Increase | 4128 |
Change | 7.2 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
cvt
fpgm
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
PPM <= 65535 | - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType® |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 3.000; ttfautohint (v1.8.4.7-5d5b) [code: version-not-detected]
[5] ofl/manufacturingconsent
🔥 FAIL Check for presence of an ARTICLE.en_us.html file (googlefonts/description/has_article)
- 🔥 FAIL This font doesn't have an ARTICLE.en_us.html file. [code: missing-article]
🔥 FAIL Check font has a license. (googlefonts/family/has_license)
- 🔥 FAIL No license file was found. Please add an OFL.txt or a LICENSE.txt file. [code: no-license]
🔥 FAIL Check Google Fonts glyph coverage. (googlefonts/glyph_coverage)
- 🔥 FAIL ofl/manufacturingconsent/ManufacturingConsent-Regular.ttf missing required codepoints:
- 0x201E
- 0x0219
- 0x1E80
- 0x02C6
- 0x1E83
- 0x02C7
- 0x1E82
- 0x0326
- 0x002A
... and 25 others [code: missing-codepoints]
⚠️ WARN Check for codepoints not covered by METADATA subsets. (googlefonts/metadata/unreachable_subsetting)
⚠️ WARN ofl/manufacturingconsent/ManufacturingConsent-Regular.ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
- U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: math, coptic, cherokee, tifinagh
- U+0305 COMBINING OVERLINE: try adding one of: coptic, elbasan, glagolitic, gothic, math
- U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
- U+0307 COMBINING DOT ABOVE: try adding one of: syriac, malayalam, todhri, old-permic, canadian-aboriginal, coptic, tai-le, math, duployan, tifinagh, hebrew
- U+030A COMBINING RING ABOVE: try adding one of: syriac, duployan
- U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
- U+030C COMBINING CARON: try adding one of: cherokee, tai-le
- U+0315 COMBINING COMMA ABOVE RIGHT: try adding math
- U+0327 COMBINING CEDILLA: try adding math
... and 3 others
Or you can add the above codepoints to one of the subsets supported by the font: latin-ext, latin [code: unreachable-subsetting]
ℹ️ INFO Check axis ordering on the STAT table. (googlefonts/STAT/axis_order)
- ℹ️ INFO All of the fonts lack a STAT table. [code: summary]
Summary
⏩ SKIP | 💥 ERROR | ✅ PASS | 🔥 FAIL | ℹ️ INFO | |
---|---|---|---|---|---|
64 | 2 | 89 | 5 | 5 | 16 |
36% | 1% | 50% | 3% | 3% | 9% |
Taken from the upstream repo https://github.com/googlefonts/manufacturing-consent-font at commit googlefonts/manufacturing-consent-font@80c3d82.
Resolves #2071
PR Checklist:
PR
QA
Specifics
primary_script
definition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsets
definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong
,chinese-simplified
,chinese-traditional
,korean
,japanese
.Release
minisite_url
definition in the METADATA.pb file for commissioned projectstags
are added for NEW FONTS