-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add Nata Sans font family #9494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @m4rc1e @emmamarichal, just a quick note to let you know I opened this new PR after accidentally closing the previous one. Thanks again for your help and feedback! |
@dnlzqn thanks for posting this! Usually we prefer an issue than a PR, so that we can discuss your project there and get consensus to add it and what will be required, and then later once our requirements are met, then we prepare a PR ourselves that is sure to pass through our onboarding validation processes quickly. But its great you are trying to make a PR directly :) I did a review here in gh and spotted a few things in the text shown, I didn't look inside your TTF, but I'm sure @emmamarichal and @m4rc1e will do an excellent review soon :) |
Thank you @davelab6 :) I'll give you a review regarding outlines as soon as possible, thanks again for your submission! |
Thanks for the feedback and for the clarification about the usual process, @davelab6 — totally noted for future contributions! I've now: Let me know if there's anything else to address. Happy to adjust anything further to align with GF standards. |
Hi @dnlzqn! First of all, thanks again for that submission, the font covers a lot of langages, that's really appreciated. Here you can find a first review: Fontspector Fails and Warns you can easily fix🔥 FAIL Check tabular widths don't have kerning. (tabular_kerning)
Outlines / alignement / Design issuesNote: for each point, check it in each masters.
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Other
FontSpector reportfontspector version: 1.0.2 Check results[4] ofl/natasans🔥 FAIL Check font has a license. (googlefonts/family/has_license)
|
Message | Languages |
---|---|
Auxiliary orthography codepoints: | * be_Cyrl (Belarusian) |
Shaper didn't attach acutecomb to uni0430 when shaping the text 'а́' | * be_Cyrl (Belarusian) |
Shaper didn't attach acutecomb to uni0435 when shaping the text 'е́' | |
Shaper didn't attach acutecomb to uni0451 when shaping the text 'ё́' | |
Shaper didn't attach acutecomb to uni0456 when shaping the text 'і́' | |
Shaper didn't attach acutecomb to uni043E when shaping the text 'о́' | |
Shaper didn't attach acutecomb to uni0443 when shaping the text 'у́' | |
Shaper didn't attach acutecomb to uni044B when shaping the text 'ы́' | |
Shaper didn't attach acutecomb to uni044D when shaping the text 'э́' | |
Shaper didn't attach acutecomb to uni044E when shaping the text 'ю́' | |
Shaper didn't attach acutecomb to uni044F when shaping the text 'я́' | |
Auxiliary orthography codepoints: | * ru_Cyrl (Russian) |
Shaper didn't attach acutecomb to uni0430 when shaping the text 'а́' | * ru_Cyrl (Russian) |
Shaper didn't attach acutecomb to uni0435 when shaping the text 'е́' | |
Shaper didn't attach acutecomb to uni0438 when shaping the text 'и́' | |
Shaper didn't attach acutecomb to uni043E when shaping the text 'о́' | |
Shaper didn't attach acutecomb to uni0443 when shaping the text 'у́' | |
Shaper didn't attach acutecomb to uni044B when shaping the text 'ы́' | |
Shaper didn't attach acutecomb to uni044D when shaping the text 'э́' | |
Shaper didn't attach acutecomb to uni044E when shaping the text 'ю́' | |
Shaper didn't attach acutecomb to uni044F when shaping the text 'я́' | |
Auxiliary orthography codepoints: | * uk_Cyrl (Ukrainian) |
Shaper didn't attach acutecomb to uni0430 when shaping the text 'а́' | * uk_Cyrl (Ukrainian) |
Shaper didn't attach acutecomb to uni0435 when shaping the text 'е́' | |
Shaper didn't attach acutecomb to uni0454 when shaping the text 'є́' | |
Shaper didn't attach acutecomb to uni0438 when shaping the text 'и́' | |
Shaper didn't attach acutecomb to uni0456 when shaping the text 'і́' | |
Shaper didn't attach acutecomb to uni0457 when shaping the text 'ї́' | |
Shaper didn't attach acutecomb to uni043E when shaping the text 'о́' | |
Shaper didn't attach acutecomb to uni0443 when shaping the text 'у́' | |
Shaper didn't attach acutecomb to uni044E when shaping the text 'ю́' | |
Shaper didn't attach acutecomb to uni044F when shaping the text 'я́' | |
Auxiliary orthography codepoints: | * bg_Cyrl (Bulgarian) |
Shaper didn't attach gravecomb to uni0430 when shaping the text 'а̀' | * bg_Cyrl (Bulgarian) |
Shaper didn't attach gravecomb to uni043E when shaping the text 'о̀' | |
Shaper didn't attach gravecomb to uni0443 when shaping the text 'у̀' | |
Shaper didn't attach gravecomb to uni044A when shaping the text 'ъ̀' | |
Shaper didn't attach gravecomb to uni044E when shaping the text 'ю̀' | |
Shaper didn't attach gravecomb to uni044F when shaping the text 'я̀' | |
Auxiliary orthography codepoints: | * sr_Cyrl (Serbian) |
Shaper didn't attach uni0302 to uni0430 when shaping the text 'а̂' | * sr_Cyrl (Serbian) |
Shaper didn't attach uni0302 to uni0435 when shaping the text 'е̂' | |
Shaper didn't attach uni0302 to uni0438 when shaping the text 'и̂' | |
Shaper didn't attach uni0302 to uni043E when shaping the text 'о̂' | |
Shaper didn't attach uni0302 to uni0443 when shaping the text 'у̂' |
⚠️ WARN Font has correct separator glyphs? (googlefonts/separator_glyphs)
⚠️ WARN The following separator glyphs are missing:
- U+2028
- U+2029 [code: missing-separator-glyphs]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that
replace the dot. (soft_dotted)
⚠️ WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: * j̑
- ɨ̏The dot of soft dotted characters should disappear in other cases, for example: * į̰̑
- į̰̏
- į̦̑
- į̦̏
- į̨̑
- į̨̏
- į̛̑
- į̛̏
- į̧̑
... and 193 others [code: soft-dotted]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
⚠️ WARN Checking OS/2 achVendID. (googlefonts/vendor_id)
⚠️ WARN OS/2 VendorID value 'NONE' is not yet recognized.
If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
[code: unknown]
ℹ️ INFO Checking OS/2 fsSelection value. (opentype/xavgcharwidth)
- ℹ️ INFO OS/2 xAvgCharWidth is 586 but it should be 585 which corresponds to the average of the widths of all glyphs in the font. These are similar values, which may be a symptom of the slightly different calculation of the xAvgCharWidth value in font editors. There's further discussion on this at com.google.fonts/test/034: xAvgCharWidth bakery vs glyphs vs font val fonttools/fontbakery#1622 [code: xAvgCharWidth-close]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
NataSans[wght].ttf | |
---|---|
Dehinted Size | 450084 |
Hinted Size | 450108 |
Increase | 24 |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
- Use smoothing along multiple axes with ClearType® | |
---|---|
[code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.001 [code: version-not-detected]
Summary
✅ PASS | ⏩ SKIP | 🔥 FAIL | ℹ️ INFO | |
---|---|---|---|---|
111 | 47 | 2 | 15 | 7 |
62% | 26% | 1% | 8% | 4% |
…lar figures, added caret positions, fixed separator glyphs, updated OFL URL, cleaned .001 glyphs, adjusted outlines, and updated METADATA.pb subsets
Hi @emmamarichal, Thanks again for your detailed review — I’ve now implemented all the changes you requested:
Let me know if anything else needs adjustment. Thanks again for your support! Best, |
This is a clean resubmission of Nata Sans, following feedback from the Google Fonts team.
METADATA.pb
,OFL.txt
, and the font file at the top level)article/
folder withARTICLE_en_us.html
andNata.svg
Thank you for your time and guidance — looking forward to your review.