Rename variable string mapping utils and move them to variableslib #4503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
reviewed
Jan 25, 2025
flax/nnx/variablelib.py
Outdated
| return VariableTypeCache[name] | ||
|
|
||
|
|
||
| def variable_name(typ: tp.Type[Variable[tp.Any]]) -> str: |
There was a problem hiding this comment.
Name suggestions: variable_type_from_name and variable_name_from_type. A bit more verbose but current names are a bit ambiguous.
cgarciae
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
variable_typeandvariable_type_nameto more concisenamed_variableandvariable_nameMove the registry that maps
nnx.Variabletypes to strings fromnnx.bridge.variablestonnx.variablelib, so that it can be used in core NNX methods likennx.Module.sowand perturb.