Skip to content

Add logical axis global context support for NNX #4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2024
Merged

Add logical axis global context support for NNX #4350

merged 1 commit into from
Nov 9, 2024

Conversation

IvyZX
Copy link
Collaborator

@IvyZX IvyZX commented Oct 31, 2024

  • Makes it possible to use the logical axis context manager in NNX annotations.
  • Move the logical axis context annotation and some rule inference part to flax.core.spmd, to be shared by Linen and NNX.
  • Some small typo fix.

@copybara-service copybara-service bot merged commit d31f290 into google:main Nov 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgarciae cgarciae cgarciae approved these changes

Assignees
No one assigned
Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IvyZX @cgarciae