Allow apply's method argument to accept submodules #3281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
force-pushed
the
method-accept-str-submodules
branch
from
6efcebd to
0a95444
Compare
Codecov Report
@@ Coverage Diff @@
## main #3281 +/- ##
==========================================
+ Coverage 82.62% 82.64% +0.01%
==========================================
Files 55 55
Lines 6359 6360 +1
==========================================
+ Hits 5254 5256 +2
+ Misses 1105 1104 -1
... and 2 files with indirect coverage changes 📢 Have feedback on the report? Share it here. |
cgarciae
force-pushed
the
method-accept-str-submodules
branch
from
0a95444 to
a0e4fe9
Compare
cgarciae
force-pushed
the
method-accept-str-submodules
branch
from
a0e4fe9 to
37cbb7d
Compare
chiamp
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to #3279. Improve apply's support string arguments to method by allowing submodules to be accepted as well.