Skip to content

Updated full_eval.ipynb & corrected to constructor #3059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

Neilblaze
Copy link
Contributor

What does this PR do?

  • In linen_intro (both .md & .ipynb), the _contructor arguments_ has been updated to _constructor arguments_ under Invoking Modules.

  • Corrected assigning → correc = correct.item() to correct = correct.item() in full_eval.

  • Moreover, a few typos and grammatical errors were discovered and have been corrected.


/cc: @cgarciae, @chiamp
✅ Properly synced using the pre-commit →  

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
    checks if that's the case).
  • The documentation and docstrings adhere to the
    documentation guidelines.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Neilblaze Neilblaze changed the title Updated to constructor & corrected full_eval.ipynb Updated full_eval.ipynb & corrected to constructor Apr 26, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3059 (2a1bef4) into main (b3945f8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3059   +/-   ##
=======================================
  Coverage   81.97%   81.97%           
=======================================
  Files          55       55           
  Lines        6031     6031           
=======================================
  Hits         4944     4944           
  Misses       1087     1087           

Copy link
Collaborator

@cgarciae cgarciae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Neilblaze, looks good!

@copybara-service copybara-service bot merged commit 6916f4d into google:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants