Allow specifying method as a string #2809
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows passing
method
as a string toapply
. This will simply get the specified attribute fromself
.Rationale
Being able to specify the method without having direct access to the instance is important to improve the ergonomics of abstractions like
TrainState
where you only have access toapply
viaTrainState.apply_fn
.Currently we promote the use of
state
like this:However, if you happen to need to use a method you now have to pass it somehow e.g:
This involves a couple of changes throughout the code base for a relatively simple operation. With the proposed change you can now specify it very simply as: