Skip to content

Added builder functions for zeros and ones initializers #2790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Jan 12, 2023

Addresses part of #2002 and is mentioned by @marcvanzee here.

Added builder functions for zeros and ones initializers.

Copy link
Collaborator

@marcvanzee marcvanzee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think it makes sense to, as a follow-up, replace all occurrences of "zeros" and "ones" in our codebase for initializing parameters with the new initializer functions, WDYT?

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

Codecov Report

Merging #2790 (871638e) into main (52be1fd) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2790      +/-   ##
==========================================
+ Coverage   81.18%   81.23%   +0.04%     
==========================================
  Files          53       53              
  Lines        5645     5659      +14     
==========================================
+ Hits         4583     4597      +14     
  Misses       1062     1062              
Impacted Files Coverage Δ
flax/linen/initializers.py 100.00% <100.00%> (ø)
flax/linen/__init__.py 100.00% <0.00%> (ø)
flax/linen/transforms.py 94.14% <0.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants