Skip to content

Add deprecation warnings and docstring pointers to flax.training.lr_schedule #2702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2022
Merged

Add deprecation warnings and docstring pointers to flax.training.lr_schedule #2702

merged 1 commit into from
Dec 12, 2022

Conversation

IvyZX
Copy link
Collaborator

@IvyZX IvyZX commented Dec 8, 2022

Fixes #2699

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
    checks if that's the case).
  • This change is discussed in a Github issue/
    discussion (please add a
    link).
  • The documentation and docstrings adhere to the
    documentation guidelines.
  • This change includes necessary high-coverage tests.
    (No quality testing = no merge!)

marcvanzee
marcvanzee approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@marcvanzee marcvanzee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@copybara-service copybara-service bot merged commit fd69b9e into google:main Dec 12, 2022
@IvyZX IvyZX deleted the lrdep branch December 12, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcvanzee marcvanzee marcvanzee approved these changes

Assignees
No one assigned
Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a deprecation warning to flax.training.lr_schedule
2 participants
@IvyZX @marcvanzee