Add serialization for Partial functions. Completes #2433 #2557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @zaxtax! Can you add a test for this? |
|
Yep!
…On Wed, 2 Nov 2022, 15:28 Cristian Garcia, ***@***.***> wrote:
Thanks @zaxtax <https://github.com/zaxtax>! Can you add a test for this?
—
Reply to this email directly, view it on GitHub
<#2557 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACCUL7U7C647UJTO6SFRDWGJ27TANCNFSM6AAAAAARNZ3DPY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
zaxtax
force-pushed
the
partial_serialization
branch
from
60f8e61 to
390b42c
Compare
Codecov Report
@@ Coverage Diff @@
## main #2557 +/- ##
=======================================
Coverage 81.15% 81.15%
=======================================
Files 51 51
Lines 5492 5493 +1
=======================================
+ Hits 4457 4458 +1
Misses 1035 1035
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates the feature suggestion of adding serialization support for Jax partial functions. This would benefit from a unit test, but otherwise uses the code from the earlier issue largely as is.
Fixes #2433