Skip to content

Update Flax Contributing.md #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Update Flax Contributing.md #2546

merged 1 commit into from
Oct 24, 2022

Conversation

8bitmp3
Copy link
Collaborator

@8bitmp3 8bitmp3 commented Oct 20, 2022

  • Expanded the section about using jupyter --sync, especially if a Markdown file is updated first.
  • Users can run python3 - not just python3.6.
  • Some formatting changes, grammar fixes, typo fixes.

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #2546 (b2e714c) into main (6b80cbb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2546   +/-   ##
=======================================
  Coverage   79.46%   79.46%           
=======================================
  Files          49       49           
  Lines        5202     5202           
=======================================
  Hits         4134     4134           
  Misses       1068     1068           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jheek jheek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@copybara-service copybara-service bot merged commit 064e6fc into main Oct 24, 2022
@copybara-service copybara-service bot deleted the flax-contributing-md branch October 24, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants