Skip to content

add rng_collection argument to Dropout #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cgarciae
Copy link
Collaborator

What does this PR do?

Fixes #2194. Parametrizes the rng collection name, defaults to dropout but it can now be specified via a constructor argument.

@cgarciae cgarciae requested a review from jheek October 17, 2022 20:41
Copy link
Member

@jheek jheek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@8bitmp3
Copy link
Collaborator

8bitmp3 commented Oct 18, 2022

👍 @cgarciae

@copybara-service copybara-service bot merged commit d6fb012 into google:main Oct 18, 2022
@cgarciae cgarciae mentioned this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make RNG name configurable in Dropout
3 participants