Skip to content

Delete flax.optim.rst #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Delete flax.optim.rst #2522

merged 1 commit into from
Oct 12, 2022

Conversation

ppwwyyxx
Copy link
Contributor

This module no longer exists

What does this PR do?

Fixes # (issue)

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
    checks if that's the case).
  • This change is discussed in a Github issue/
    discussion (please add a
    link).
  • The documentation and docstrings adhere to the
    documentation guidelines.
  • This change includes necessary high-coverage tests.
    (No quality testing = no merge!)

This module no longer exists
@cgarciae
Copy link
Collaborator

@andsteing can we delete this now?

@cgarciae cgarciae self-assigned this Oct 11, 2022
@8bitmp3
Copy link
Collaborator

8bitmp3 commented Oct 12, 2022

cc @jheek @levskaya @IvyZX

Copy link
Collaborator

@levskaya levskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@levskaya
Copy link
Collaborator

levskaya commented Oct 12, 2022

@cgarciae - I see some doctest failures of the form AttributeError: module 'jax.test_util' has no attribute 'check_eq' <-- is this a new issue cropping up? (obviously unrelated to this PR)

@copybara-service copybara-service bot merged commit a479e13 into google:main Oct 12, 2022
@cgarciae
Copy link
Collaborator

@levskaya never seen this. Is it happening on main too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants