Skip to content

Use gfile.remove for files because it doesn't work on GCS files. #2518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2022
Merged

Use gfile.remove for files because it doesn't work on GCS files. #2518

merged 2 commits into from
Oct 10, 2022

Conversation

IvyZX
Copy link
Collaborator

@IvyZX IvyZX commented Oct 10, 2022

Fixes #2508

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
    checks if that's the case).

@IvyZX IvyZX changed the title Use gfile.remove for files because it doesn't work on GCS directories. Use gfile.remove for files because it doesn't work on GCS files. Oct 10, 2022
cgarciae
cgarciae approved these changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@cgarciae cgarciae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@copybara-service copybara-service bot merged commit b7d2840 into google:main Oct 10, 2022
@IvyZX IvyZX deleted the gcs-gfile branch November 7, 2022 22:19
@IvyZX IvyZX mentioned this pull request Nov 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgarciae cgarciae cgarciae approved these changes

Assignees

@cgarciae cgarciae

Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GCS-related error during deletion of old checkpoints with save_checkpoint
2 participants
@IvyZX @cgarciae