Skip to content

Adds CallSetupUnboundModuleError #2496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2022
Merged

Adds CallSetupUnboundModuleError #2496

merged 1 commit into from
Oct 10, 2022

Conversation

cgarciae
Copy link
Collaborator

@cgarciae cgarciae commented Oct 3, 2022 •
edited
Loading

What does this PR do?

Fixes #667. Raises a new CallSetupUnboundModuleError when trying to call .setup() while scope is None.

@cgarciae cgarciae requested a review from jheek October 4, 2022 14:13
jheek
jheek approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@jheek jheek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@copybara-service copybara-service bot merged commit e229150 into google:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jheek jheek jheek approved these changes

Assignees
No one assigned
Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Directly calling module.setup() should raise an exception
2 participants
@cgarciae @jheek