Update landing page example #2366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
added
the
Priority: P2 - no schedule
cgarciae
force-pushed
the
improve-landing-page-example
branch
from
39f1aca to
f315721
Compare
Codecov Report
@@ Coverage Diff @@
## main #2366 +/- ##
==========================================
- Coverage 79.08% 78.98% -0.11%
==========================================
Files 49 49
Lines 5188 5139 -49
==========================================
- Hits 4103 4059 -44
+ Misses 1085 1080 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
levskaya
approved these changes
Oct 6, 2022
8bitmp3
reviewed
Oct 6, 2022
8bitmp3
reviewed
Oct 6, 2022
8bitmp3
reviewed
Oct 6, 2022
8bitmp3
reviewed
Oct 6, 2022
8bitmp3
reviewed
Oct 6, 2022
8bitmp3
reviewed
Oct 6, 2022
| y = model.apply(variables, x) # make forward pass | ||
| x = jnp.empty((4, 28, 28, 1)) # fake data | ||
| variables = model.init(PRNGKey(42), x) # initialize weights | ||
| y = model.apply(variables, x) # make forward pass |
There was a problem hiding this comment.
Suggestion: To make the grammar sound a bit better, maybe
Suggested change
| y = model.apply(variables, x) # make forward pass | |
| y = model.apply(variables, x) # forward propagate the input |
cgarciae
force-pushed
the
improve-landing-page-example
branch
from
3558870 to
c62c428
Compare
|
@8bitmp3 thanks for the feedback! Made the most of the changes except I left "make forward pass" as it sounded better in my head (feel free to push back). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2332