Add __getattribute__ with lazy setup trigger.

[levskaya]

Currently there's a dumb difference in behavior when accessing submodules defined in setup() vs submodules passed in as dataclass attributes - the former will work in more situations as getattr triggers setup but the latter won't as getattribute does not currently trigger setup. This PR fixes that discrepancy.

[codecov-commenter]

Codecov Report

Merging #2028 (aca3e29) into main (0c647cb) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2028      +/-   ##
==========================================
+ Coverage   74.86%   74.97%   +0.10%     
==========================================
  Files          59       59              
  Lines        5037     5042       +5     
==========================================
+ Hits         3771     3780       +9     
+ Misses       1266     1262       -4     

Impacted Files	Coverage Δ
flax/linen/module.py	94.85% <100.00%> (+0.85%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c647cb...aca3e29. Read the comment docs.

[levskaya]

One of the main applications of this that users ask for is being able to apply deeply nested submodules like so:

y = nn.apply(lambda top_module, x: top_module.a.b.c.some_method(x), foo)(variables, x)

where a,b,c might be dataclass attributes OR setup defined submodules. This is a lot nicer than having to hack around the variable tree.

[marcvanzee]

@levskaya this is a nice change and it would be useful to add this to the CHANGELOG.md. Would you mind doing this?

[levskaya]

@marcvanzee - I actually had to roll this back in #2034 because it was breaking some user code. It might take me longer to land this.

[marcvanzee]

Just realized this is actually rolled back, so please disregard my comment.

…

On Mon, Apr 11, 2022 at 1:32 PM Marc van Zee ***@***.***> wrote: @levskaya <https://github.com/levskaya> this is a nice change that would be useful to add this to the CHANGELOG.md. Would you mind doing this? — Reply to this email directly, view it on GitHub <#2028 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABL7BATQVSS5R3NWXCTX2TVEQEVDANCNFSM5SULKUDA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- --- Marc van Zee