-
Notifications
You must be signed in to change notification settings - Fork 85
Conversation
I actually removed this on purpose for the system admin pages. I want to avoid any hint that the user is in a realm context when doing system admin tasks. |
And I think the bar at the top is misleading the user into believe they are operating on realm settings vs system settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the orange banner. I'm not sure I like the code duplication between the admin bar and the regular nav. I hear you on exiting vim, but remember that the average user won't be interacting with this part of the system.
Sorry - tried to remove most of the duplication (I think it'll be a bit more maintainable decomposed a bit). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sethvargo, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Seth Vargo <[email protected]>
New changes are detected. LGTM label has been removed. |
New changes are detected. LGTM label has been removed. |
Proposed Changes
Release Note