More consistent UI and project structure #533
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
googlebot
added
the
cla: yes
|
Since HTML changes indentation: https://github.com/google/exposure-notifications-verification-server/pull/533/files?w=1 |
| </div> | ||
| <div class="list-group-item"> | ||
| <h5 class="mb-1">Expiry</h5> | ||
| <span id="code-expires-at" class="sm text-danger"> </span> |
There was a problem hiding this comment.
Empty elements have no height, so this created a weird FOUT on page load. Giving it a space solves that problem.
| @@ -0,0 +1,75 @@ | |||
| {{define "login/select-realm"}} | |||
There was a problem hiding this comment.
Sigh. I don't know why git mv never works for me 😦
There was a problem hiding this comment.
Anyway, this is pretty much a straight move into the login folder.
| "github.com/google/exposure-notifications-verification-server/pkg/database" | ||
| ) | ||
|
|
||
| func (c *Controller) HandleSelectRealm() http.Handler { |
There was a problem hiding this comment.
Moved this into login package and made it a single function that renders the form or processes the selection based on the request method like we do elsewhere.
|
/assign @whaught |
Been trying to clean this up for awhile. I went through all our HTML pages and made their styles consistent with light background, card bodies with shadow, form spacing, etc.
Release Note