This repository was archived by the owner on Jul 12, 2023. It is now read-only.
Add realm configuration for requiring dates #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
googlebot
added
the
cla: yes
sethvargo
commented
Sep 10, 2020
| @@ -893,6 +893,26 @@ func (db *Database) getMigrations(ctx context.Context) *gormigrate.Gormigrate { | |||
| return nil | |||
| }, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Why not gorm.AutoMigrate? Because you can't set a NOT NULL constraint and DEFAULT at the same time when there are existing rows in the database. Postgres creates them with NULL, then backfills the default... but that violates the NOT NULL constraint. So we have to create the column as nullable, wait for the tx to finish, then mark it as not nullable.
whaught
reviewed
Sep 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-519
This adds a new realm-specific configuration for requiring a date. The default is false and backfilled as false.
Release Note