Add middleware for debug headers #497
Conversation
googlebot
added
the
cla: yes
pkg/controller/middleware/debug.go
Outdated
| // ProcessDebug adds additional debugging information to the response if the | ||
| // request included the "X-Debug" header with any value. | ||
| func ProcessDebug(ctx context.Context) mux.MiddlewareFunc { | ||
| header := "x-debug" |
There was a problem hiding this comment.
nit: seems like this should be a const
There was a problem hiding this comment.
also - I'm not sure x-debug is the right header, maybe something like x-build-info ?
There was a problem hiding this comment.
Made them constants. The return headers are x-buildinfo-*. This is the request header, and I'd like to give us flex to add other debug information if we wanted to in the future.
If the request sends an x-debug header with any value, the response headers will be populated with the build ID and tag.
sethvargo
force-pushed
the
sethvargo/debug
branch
from
4e35a84 to
035b543
Compare
|
@mikehelmick PTAnotherL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If the request sends an x-debug header with any value, the response headers will be populated with the build ID and tag.
Release Note
/cc @icco