Skip to content
This repository was archived by the owner on Jul 12, 2023. It is now read-only.

Add redis opencensus metrics to the server #361

Merged
merged 5 commits into from
Aug 25, 2020
Merged

Add redis opencensus metrics to the server #361

merged 5 commits into from
Aug 25, 2020

Conversation

taddari
Copy link
Contributor

@taddari taddari commented Aug 25, 2020

Fixes #266

Proposed Changes

  • Change redigo to opencensus/redigo
  • Change redisstore to instrumented redisstore

Release Note

Add redis opencensus metrics to the verification server, this will enable to monitor problems with redis connections itself.

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Aug 25, 2020
@google-oss-robot
Copy link

Hi @taddari. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sethvargo
Copy link
Member

Redis bits look good. Gonna defer to @icco on the metrics.

Copy link
Contributor

@mikehelmick mikehelmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM, but will wait until not draft

@mikehelmick
Copy link
Contributor

/ok-to-test

@icco
Copy link
Contributor

icco commented Aug 25, 2020

@taddari: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-en-server-release-unit 1d545e6 link /test pull-en-server-release-unit

This is just saying you need to run go mod tidy

@icco
Copy link
Contributor

icco commented Aug 25, 2020

/assign

@taddari
Copy link
Contributor Author

taddari commented Aug 25, 2020

/retest

@taddari taddari marked this pull request as ready for review August 25, 2020 20:00
@icco
Copy link
Contributor

icco commented Aug 25, 2020

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: icco, taddari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 9e6d015 into google:main Aug 25, 2020
@google google locked and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open Census for Redis
6 participants