Skip to content

Add support for BS ScrollSpy to show active TOC entry #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Jun 13, 2025

  • Proposed solution for New Feature: Navigation indication on the right TOC #349
  • Adds support for Bootstrap's Scrollspy for the right-side TOC nav
  • Adds an "On this page" title/heading for the TOC. I'm unsure about this, but wanted to test it out. Please give me your feedback.
  • Fixes a spacing issue with TOC being too close to page meta links. (I was sure I had an issue open for that but I can't find it.)

Previews

Screenshot

image

@chalin chalin added UX design/style Front-end site design / styling labels Jun 13, 2025
@MarkvanMents
Copy link

Looks nice.
I don't particularly like the On this page - our solution is to have the document title at the top with an href to take the reader all the way to the top of the document.
image
We also don't have the selected line indented, we just add the bar to the left and add bold.
But would be nice to have this OOTB in Docsy.

@chalin chalin mentioned this pull request Jun 13, 2025
2 tasks
@chalin
Copy link
Collaborator Author

chalin commented Jun 13, 2025

Thanks for the feedback @MarkvanMents, and the proposal. Let's continue the discussion about the TOC heading via:

@chalin chalin added this to the 25Q2 milestone Jun 13, 2025
@chalin chalin force-pushed the chalin-im-bs-scrollspy-2025-06-12 branch from 8782d66 to a12acc1 Compare June 13, 2025 11:31
@chalin chalin merged commit 4323d09 into google:main Jun 13, 2025
11 checks passed
@chalin chalin deleted the chalin-im-bs-scrollspy-2025-06-12 branch June 13, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/style Front-end site design / styling UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants