Skip to content

Accessibility color fixes, and falling back to BS defaults for typography and color #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 13, 2025
Merged

Accessibility color fixes, and falling back to BS defaults for typography and color #2285

merged 7 commits into from
Jun 13, 2025

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Jun 12, 2025 •
edited
Loading

  • Improves accessibility by fixing color contrast issues, see below for screenshots.
    • Context: it is very challenging to define theme colors that are meaningful, satisfy accessibility requirements, and work well in both light and dark modes. The Bootstrap team has done a great job. This PR just falls back on Bootstrap defaults.
  • Fixes Accessibility issues due to theme colors #2284
  • Contributes to Docsy/User-guide "skin" styles should be factored out and/or dropped in some cases #1655
  • Drops Docsy typography and color overrides. Falls back to Bootstrap defaults.
  • I've kept the Google Font config, but explain how to enable it in the UG (set one var to true)
  • Names spaces a few Docsy specific SASS variables
  • Adds automation to update the Bootstrap variables in assets/scss/_variables_forward.scss.
  • Adds a rudimentary "Tests" page

Previews

Screenshots

Before After
Image image

@chalin chalin changed the title Accessibility color fixes and falling back to BS defaults for typography and color Accessibility color fixes, and falling back to BS defaults for typography and color Jun 12, 2025
@chalin chalin force-pushed the chalin-im-clean-up-colors-2025-06-12 branch from ef2adff to 699862d Compare June 12, 2025 18:00
@chalin chalin mentioned this pull request May 23, 2025
Open
2 tasks
@chalin chalin force-pushed the chalin-im-clean-up-colors-2025-06-12 branch from 699862d to 1cc4160 Compare June 12, 2025 18:01
tiffany76
tiffany76 approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review the code, but the text looks good to me, with a couple tiny fixes.

svrnm
svrnm approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the new colors 👍

@chalin chalin force-pushed the chalin-im-clean-up-colors-2025-06-12 branch from a9a3af8 to 5ae725b Compare June 13, 2025 01:32
@chalin chalin force-pushed the chalin-im-clean-up-colors-2025-06-12 branch from 5ae725b to eb9d768 Compare June 13, 2025 09:09
@chalin chalin merged commit aa0f617 into google:main Jun 13, 2025
11 checks passed
@chalin chalin deleted the chalin-im-clean-up-colors-2025-06-12 branch June 13, 2025 11:30
@chalin chalin mentioned this pull request Jun 13, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

@LisaFC LisaFC LisaFC approved these changes

@tiffany76 tiffany76 tiffany76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessibility issues due to theme colors
4 participants
@chalin @svrnm @LisaFC @tiffany76