-
Notifications
You must be signed in to change notification settings - Fork 273
feat: use macros for defining external repositories #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sudoforge
commented
Nov 30, 2020
I can't see why the While this is functional, I think it would be best to add rules for executing migrations via different targets. I've created another issue to track this effort: #147 |
One suggestion I have is to rename this workspace to something more canonical in the Bazel ecosystem -- something along the lines of |
Hi! Thanks for the contribution. The reason for the failure is that the new BUILD file doesn't contain the Apache License header. Would you mind adding it? Thanks!! Re workspace rename: Sounds good to me. Probably better to put it in a different PR, as we merge each PR in a single commit internally. Thanks again! |
Hmm, seems like there might be an additional error to check in the |
Checking in -- if a maintainer can let me know what the error with the Also going to run through the dep macros and see if there's anything that isn't necessary for external consumers (and move them to the workspace) |
@mikelalcon sorry to ping you directly, but when you have a chance next week, can you please check the |
Hi! Sorry for the late response!The reason is the new BUILD file in the root that we don't want to import. I've sent an internal change to fix it. Could you try again? Thanks! |
Was travelling earlier today, but I've rebased on top of |
+1! This would greatly improve the usability in my use case. Is there anything blocking? |
This patch adds macros that wrap around this workspace's external dependencies: - `//:repositories.bzl%copybara_repositories` - `//:repositories.go.bzl%copybara_go_repositories` - `//:repositories.maven.bzl%copybara_maven_repositories` The primary motivation for this is to enable easier loading of copybara from within external repositories. Prior to this patch, those external repositories would need to re-define each and every dependency listed in this repository's WORKSPACE file. With this patch, those external repositories need only to load and call the macros (shown above). An empty BUILD file is also added in this patch as it is necessary in order to refer to the files in the workspace root. closes #73
@tsawada as far as I know, the only thing that this CL needs is a review and merge by a Copybara maintainer. |
@mikelalcon could I bother you to take a look at the internal job that's failing? |