Skip to content

Would be good to refactor NonReversibleValidationException into exception package #159

Closed
@ignite1771

Description

@ignite1771

Expected Behavior

All exception classes are categorized into the exception package.

Current Behavior

package com.google.copybara;
import net.starlark.java.eval.EvalException;
/**
* Exception thrown when a {@link Transformation} is not reversible but the configuration asked for
* the reverse.
*
* TODO(malcon): Move to the exception package
*/
public class NonReversibleValidationException extends EvalException {
public NonReversibleValidationException(String message) {
super(message);
}
public NonReversibleValidationException(String message, Throwable cause) {
super(message, cause);
}
}

There is a TODO in the comment of the file implies that this class should be also categorized into exception package.

Possible solution

I would like to send a PR to this, for refactoring the class and solving the affected bazel build dependency configuration.
By doing so, the source code would have better modularity.


Any pointers would be greatly appreciated.
Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions