Skip to content

Adding Production Instrumentation Reporter tool to Closure compiler #3688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2020

Conversation

patrick-sko
Copy link
Contributor

@patrick-sko patrick-sko commented Sep 15, 2020

This PR contains the code for the production instrumentation reporter tool. The code was reviewed in a separate PR on a different github repo: patrick-sko/instrumentation-reporter#2.

The minor changes between that PR and this one is I made a change to the unit test. I shrunk the size of the golden files by a lot to be more manageable.

In addition to the unit test changed, I also modified the BUILD.bazel to create a separate Jar file for the reporter.

This PR is the final step of the following feature proposal: https://docs.google.com/document/d/1uvEazsDdX0w4fRhREESvr_w7YX7JYNe27e5bD-CBeGM/edit?usp=sharing

@google-cla
Copy link

google-cla bot commented Sep 15, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 15, 2020
@patrick-sko patrick-sko reopened this Sep 15, 2020
@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 15, 2020
@patrick-sko
Copy link
Contributor Author

@googlebot I signed it!

@patrick-sko
Copy link
Contributor Author

@lauraharker Hey Laura, do you think you would be able to look this over/merge it?

@lauraharker
Copy link
Contributor

Thanks, Patrick. Working sending for internal review now.

@lauraharker
Copy link
Contributor

FYI, I moved the testdata files internally to be in the same directory as ProductionInstrumentationReporterTest.java, since that works better with how the internal Google BUILD files are set up.

No action needed here though.

@copybara-service copybara-service bot merged commit 146bf84 into google:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants