Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate regular Maven release deployment #4220

Open
lauraharker opened this issue Feb 18, 2025 · 4 comments
Open

Automate regular Maven release deployment #4220

lauraharker opened this issue Feb 18, 2025 · 4 comments
Assignees

Comments

@lauraharker
Copy link
Contributor

We want to start regularly pushing Maven releases. I'll work with @jDramaix and @12wrigja on automating this process.

Possibly related issues: #4215 , #4168, #4208, #4161

@lauraharker lauraharker self-assigned this Feb 18, 2025
copybara-service bot pushed a commit that referenced this issue Feb 21, 2025
We'll automate updating this in a followup.

The Piper CL # corresponds to the "PiperOrigin-RevId:" in a commit message, e.g. "PiperOrigin-RevId: 728717544" from fdda0c3

#4220

PiperOrigin-RevId: 729548934
@lauraharker
Copy link
Contributor Author

The general plan is to:

The goal of https://github.com/google/closure-compiler/blob/master/.github/piper-cut-cl.json is so that there's some signal that a given commit is good & safe to cut a release at, since we do a lot of internal testing already before releasing.

We also currently do internal releases at least 1x per week, sometimes 4x.

@thheller
Copy link

Any estimate on this? The last maven release is over a year old and I'd like to test some of the newer stuff?

@lauraharker
Copy link
Contributor Author

I plan to try and push a Maven release this week manually, & then we'll work on more automation

copybara-service bot pushed a commit that referenced this issue Apr 3, 2025
The protobuf bump in particular is to fix a C++ linking issue when building the Sonatype bundles:

: (Exit 1): gcc failed: error executing CppLink command (from target @@protobuf+//:protoc) /usr/bin/gcc @bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/protobuf+/protoc-0.params
collect2: fatal error: cannot find 'ld'
compilation terminated.

Looks like the older version is causing something to use the 'gold' linker, which is being removed : https://lists.gnu.org/archive/html/info-gnu/2025-02/msg00001.html.

#4220

PiperOrigin-RevId: 743643458
lauraharker added a commit that referenced this issue Apr 3, 2025
The protobuf bump in particular is to fix a C++ linking issue when building the Sonatype bundles:

: (Exit 1): gcc failed: error executing CppLink command (from target @@protobuf+//:protoc) /usr/bin/gcc @bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/protobuf+/protoc-0.params
collect2: fatal error: cannot find 'ld'
compilation terminated.

Looks like the older version is causing something to use the 'gold' linker, which is being removed : https://lists.gnu.org/archive/html/info-gnu/2025-02/msg00001.html.

#4220

PiperOrigin-RevId: 743643458
@lauraharker
Copy link
Contributor Author

I've pushed v20250402 to Sonatype: https://repo1.maven.org/maven2/com/google/javascript/closure-compiler/v20250402/. Should show up in https://mvnrepository.com/artifact/com.google.javascript/closure-compiler soon.

Since it's been more than a year, I wouldn't be surprised if something is broken. Please comment here if so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants