-
Notifications
You must be signed in to change notification settings - Fork 2.4k
reduce inotify watch #3354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce inotify watch #3354
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @MingZhang-YBPS. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3850045
to
dcb1803
Compare
/ok-to-test |
2444417
to
34cf13c
Compare
Hi @iwankgb , could you please help to review? Thank you! |
@MingZhang-YBPS, looks legit to me. Could you squash the commits, please? |
fc9efbc
to
02478a6
Compare
done, could you please approve the test workflow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is on hold. NewRawContainerWatcher()
is called in Kubernetes
Only setup inotify watch for included metrics
fix #3353
Before the change, number of container is 190+ , and number of inotify watch is 4800+
After this change, the number of inotify watch is 2052