Skip to content

reduce inotify watch #3354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

MingZhang-YBPS
Copy link
Contributor

@MingZhang-YBPS MingZhang-YBPS commented Jul 22, 2023

Only setup inotify watch for included metrics

fix #3353

Before the change, number of container is 190+ , and number of inotify watch is 4800+

lanxin_20230720171104

After this change, the number of inotify watch is 2052

image

@google-cla
Copy link

google-cla bot commented Jul 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@k8s-ci-robot
Copy link
Collaborator

Hi @MingZhang-YBPS. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iwankgb
Copy link
Collaborator

iwankgb commented Jul 22, 2023

/ok-to-test

@MingZhang-YBPS
Copy link
Contributor Author

MingZhang-YBPS commented Jul 24, 2023

Hi @iwankgb , could you please help to review? Thank you!

@iwankgb
Copy link
Collaborator

iwankgb commented Jul 25, 2023

@MingZhang-YBPS, looks legit to me. Could you squash the commits, please?

@MingZhang-YBPS
Copy link
Contributor Author

@MingZhang-YBPS, looks legit to me. Could you squash the commits, please?

done, could you please approve the test workflow?

Copy link
Collaborator

@iwankgb iwankgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is on hold. NewRawContainerWatcher() is called in Kubernetes

@iwankgb iwankgb merged commit fdd3d91 into google:master Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unneccessary inotify watch created for those not included metrics
3 participants