skip venv, .downloads and third_party with isort and pyink. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually tested that format.sh works as intended in my local setup. BUG=fix dev workflow
hheydary
approved these changes
May 18, 2024
| pyink --pyink-use-majority-quotes --pyink-indentation 2 ./ | ||
| isort --profile google --multi-line 7 --skip .downloads ./ | ||
| pyink --pyink-use-majority-quotes --pyink-indentation 2 --extend-exclude third_party --extend-exclude .downloads ./ | ||
| isort --profile google --multi-line 7 --skip .downloads ./ --skip venv --skip third_party |
There was a problem hiding this comment.
nit: isort --profile google --multi-line 7 --skip .downloads --skip venv --skip third_party ./
advaitjain
added a commit
to advaitjain/ai-edge-torch
that referenced
this pull request
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually tested that format.sh works as intended in my local setup.
format.sh now matches test_code_style.sh:
ai-edge-torch/ci/test_code_style.sh
Lines 59 to 67 in 19a168c
BUG=fix dev workflow