Adding support for cnn face detector #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless this is added, dlib will not be built using -fPIC and will not be able to be linked with PHP later.
CNN face detector (deep learning face detection) is modeled as PHP class. Currently, it only has constructor (which loads a model) and detect() method. I tried to make it resamble to Python implementation. Similar to Python, also added support for upsampling. Returned value is array with numbers as keys where number of keys is equal to number of found faced. Each element is associative array that has "top", "left", "right", "bottom" and "detection_confidence" keys. All errors are propagated using exceptions. Added two new error tests. I didn't want to rely on presence of model, so tests are not having great coverage. If we are OK to download models in tests, it would allow us to have far better coverage. What is missing: * Testing with models (should we test that?) * detect_mult method (similar to what Python have; however, I consider that this should not block pushing this change)
|
Thanks a lot! If you need anything, let me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNN face detector (deep learning face detection) is modeled as
PHP class. Currently, it only has constructor (which loads a model)
and detect() method. I tried to make it resamble to Python implementation.
Similar to Python, also added support for upsampling. Returned value
is array with numbers as keys where number of keys is equal to number
of found faced. Each element is associative array that has "top", "left",
"right", "bottom" and "detection_confidence" keys.
All errors are propagated using exceptions.
Added two new error tests. I didn't want to rely on presence of model,
so tests are not having great coverage. If we are OK to download models
in tests, it would allow us to have far better coverage.
What is missing:
that this should not block pushing this change)