Skip to content

Mention -DBUILD_SHARED_LIBS in cmake of dlib #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Mention -DBUILD_SHARED_LIBS in cmake of dlib #1

merged 1 commit into from
Jul 2, 2018

Conversation

stalker314314
Copy link
Contributor

Unless this is added, dlib will not be built using -fPIC and will not be able to be linked with PHP later.

Unless this is added, dlib will not be built using -fPIC and will not be able to be linked with PHP later.
@goodspb goodspb merged commit 77f73de into goodspb:master Jul 2, 2018
@goodspb
Copy link
Owner

goodspb commented Jul 2, 2018

Thank you for pointing this out. I actually can't link to PHP in Ubuntu, only work in MAC. I am new to C++( cmake ).

@stalker314314
Copy link
Contributor Author

No problem, not that I am super experienced either:) if it helps you, pdlib compiles perfectly on Ubuntu for me!:) (once this -D flag is added).

I am planning to use dlib from PHP and I would extend your project, if that is OK with you (better than creating my own...)? Scenario is similar to what you are doing - face recongition. For example, I would add missing functions from https://github.com/davisking/dlib/blob/master/python_examples/face_clustering.py. chinese whisperers etc.?

@goodspb
Copy link
Owner

goodspb commented Jul 3, 2018

I am great to hear that you are interested in this project. Welcome to extend it. I am now adding functions: http://dlib.net/dnn_face_recognition_ex.cpp.html

@stalker314314
Copy link
Contributor Author

This is exactly what I wanted to add!:) great. So, just to confirm - you will add chinese_whisperers function? If you will, I will wait. If you will not, let me know, so I can start on that!

@goodspb
Copy link
Owner

goodspb commented Jul 4, 2018

Aha? I don't understand what "chinese_whisperers" mean? Can you show me some reference?

@stalker314314
Copy link
Contributor Author

chinese_whispers is one of the functions that is used in http://dlib.net/dnn_face_recognition_ex.cpp.html. It is defined here.

So, are you planning to add chinese_whispers too or I can/should do it?:)

@goodspb
Copy link
Owner

goodspb commented Jul 5, 2018

Oh, I see. Let me do that. I am processing now, but need more time.

@stalker314314
Copy link
Contributor Author

Great! If you need help, I am offering myself:) just ping:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants