Payment service: fixed race condition in PaymentProcessor #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `NotifyPayment` got called during processing of `SchedulePayment` (which happened when running `debit_note_flow` example with dummy driver) it would fail because the payment order had not been saved in the database yet. To avoid this race condition (and possibly others) PaymentProcessor has been wrapped in a mutex. This allowed to remove the mutex from DriverRegistry. Also, sending `SendPayment` message needs to be done via `Arbiter::spawn` now to avoid deadlock in case it is sent to the same node. Signed-off-by: Adam Wierzbicki <[email protected]>
pnowosie
approved these changes
Mar 11, 2021
maaktweluit
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
NotifyPaymentgot called during processing ofSchedulePayment(which happened when runningdebit_note_flowexample with dummy driver) it would fail because the payment order had not been saved in the database yet.To avoid this race condition (and possibly others)
PaymentProcessorhas been wrapped in a mutex. This allowed to remove the mutex fromDriverRegistry. Also, sendingSendPaymentmessage needs to be done viaArbiter::spawnnow to avoid deadlock in case it is sent to the same node.Testing instructions: Run
debit_note_flowwith dummy driver. (A few times preferably)