Skip to content

Changed default GSB endpoint to UNIX socket #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

Wiezzel
Copy link

@Wiezzel Wiezzel commented Feb 9, 2021

Testing instructions:

  1. Run yagna and look for message about GSB listening on UNIX socket.
$ cargo run service run
[2021-02-09T16:08:51Z INFO  yagna] Starting yagna service! Version: 0.6.0-rc6 (4e6629dc 2021-02-08).
Log is written to /home/adam/yagna/test/yagna_rCURRENT.log
[2021-02-09T16:08:51Z INFO  yagna] Data directory: /home/adam/yagna/test
[2021-02-09T16:08:51Z INFO  ya_sb_router] Router listening on: "/tmp/yagna.sock"
  1. Check file permissions (should be 700 – only owner allowed to connect).
$ stat /tmp/yagna.sock
  File: yagna.sock
  Size: 0               Blocks: 0          IO Block: 4096   socket
Device: 804h/2052d      Inode: 4332642     Links: 1
Access: (0700/srwx------)  Uid: ( 1001/    adam)   Gid: ( 1001/    adam)
Access: 2021-02-09 17:58:24.924073454 +0100
Modify: 2021-02-09 17:58:24.556082429 +0100
Change: 2021-02-09 17:58:24.556082429 +0100
 Birth: -
  1. Run some CLI commands and check if they work.

@Wiezzel Wiezzel self-assigned this Feb 9, 2021
@Wiezzel Wiezzel requested a review from a team February 9, 2021 16:59
Copy link
Contributor

@pnowosie pnowosie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Wiezzel Wiezzel force-pushed the wiezzel/unix_socket branch 2 times, most recently from d4ebf78 to a2e14db Compare February 11, 2021 15:24
@Wiezzel
Copy link
Author

Wiezzel commented Feb 15, 2021

@maaktweluit Bump

Copy link
Contributor

@maaktweluit maaktweluit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! my review from Thursday was still pending..

Please update the commit to ya-service-bus after the other PR got merged

besides that:
LGTM!

@Wiezzel Wiezzel force-pushed the wiezzel/unix_socket branch from a2e14db to f6f4c90 Compare February 15, 2021 16:40
@Wiezzel Wiezzel requested a review from maaktweluit February 15, 2021 16:41
Copy link
Contributor

@maaktweluit maaktweluit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Wiezzel Wiezzel merged commit 47255bb into payments/beta-1 Feb 16, 2021
@Wiezzel Wiezzel deleted the wiezzel/unix_socket branch February 16, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants