Get faucet url from envvar or resolve srv record #1000
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SRV record is set (thanks to @Wiezzel who figured it out).
Testing shows that SRV record is resolved only to hostname & port
2021-02-03T07:29:38Z INFO faucet_srv] Resolved faucet host: "yacn.dev.golem.network:5778"
Assumptions
For now I'm taking the following assumptions (tech debt)
zk/donatex
ZKSYNC_FAUCET_ADDR
value is taken as is without any changesTests
Run withdrawal example with log level
debug
. Example of [successful withdrawal].