forked from apache/datafusion
-
Notifications
You must be signed in to change notification settings - Fork 0
[POC] Introduce selection vector for hash aggregate #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
goldmedal
wants to merge
41
commits into
feat/selection-vector-partition
Choose a base branch
from
feat/hash-agg-sv
base: feat/selection-vector-partition
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
commented
Apr 20, 2025
Comment on lines
+118
to
+125
if let Some(sv) = sv { | ||
for idx in sv { | ||
let v = if cols[0].as_primitive::<T>().is_null(*idx) { | ||
None | ||
} else { | ||
Some(cols[0].as_primitive::<T>().value(*idx)) | ||
}; | ||
let group_id = match v { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the selection indices, get the record by index iteratively.
goldmedal
commented
Apr 20, 2025
Comment on lines
+829
to
+836
let mut sv_mode = false; | ||
let selection: Vec<usize> = | ||
if let Some(array) = batch.column_by_name(SELECTION_FIELD_NAME) { | ||
sv_mode = true; | ||
array.as_boolean().values().set_indices().collect() | ||
} else { | ||
vec![] | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where to get the selection vector.
1 task
ab5a0e3
to
0a0055d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This PR only implements some of the hash aggregations:
count
and the agg function, which usesGroupsAccumulator
.Benchmakr Result