Implement selection vector partitioning mode for HashAggregate #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 29, 2025
goldmedal
force-pushed
the
feat/zero-copy-hash-agg
branch
from
52b5599 to
f3be490
Compare
github-actions
bot
added
documentation
goldmedal
force-pushed
the
feat/selection-vector-partition
branch
from
5bdf2d7 to
b28bf32
Compare
goldmedal
force-pushed
the
feat/selection-vector-partition
branch
from
b28bf32 to
c6b33da
Compare
goldmedal
force-pushed
the
feat/zero-copy-hash-agg
branch
from
f3be490 to
170fe69
Compare
github-actions
bot
removed
documentation
Dandandan
reviewed
Mar 31, 2025
| @@ -687,6 +698,8 @@ impl Stream for GroupedHashAggregateStream { | |||
| Some(Ok(batch)) => { | |||
| let timer = elapsed_compute.timer(); | |||
|
|
|||
| let batch = self.filter_by_selection_vector(batch)?; | |||
There was a problem hiding this comment.
So instead of this - it should compute the indices and only do work for group_aggregate_batch (I think there need to be some more changes there).
goldmedal
force-pushed
the
feat/selection-vector-partition
branch
from
c6b33da to
d10ec22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?