Korean translation 행운을 빕니다

[goldbergyoni]

https://github.com/i0natan/nodebestpractices/blob/korean-translation/README.md

@XoDNr - Korean translation can be officially kicked-off. You're the lead! I'll be at your disposal should you need anything. A branch was created (link below), you should have permissions to it, everyone else must PR before changing anything there.

I would ask/recommend only 2 important guidelines:

Keep the same content & formatting - the focus is on translation, should anyone want to modify the content or the graphics - let's PR first in English and them translate to Korean
Duplicate pages - the content should be translated over a page duplication. Readme.MD became Readme.korean.MD, all other files should be duplicated similarly. So the number of English & Korean pages should be the same. Will create a bold link from the English home page to the Korean home page (with bold credit of course...)

https://github.com/i0natan/nodebestpractices/blob/korean-translation/README.md

[XoDNr]

Thank you so much! i'll do my best! Good luck to all you guys, 행운을 빕니다!

[goldbergyoni]

Our pleasure to have you here, LMK whether you need anything to push forward.

I suggest pushing a short version (e.g. one bullet), solicit feedback whether all is done right and then proceed

[goldbergyoni]

@XoDNr no rush, just checking whether everything is clear and if I assist in anyway?

[hinco114]

@i0natan It looks like doesn't progress... Can I participate in this project?

[goldbergyoni]

@hinco114 our pleasure to have you hear, I suggest we first ping @XoDNr and ask for his advice?

[hinco114]

@XoDNr 저도 같이 작업을 하고 싶은데 어떻게 참여 할 수 있을까요?

[hinco114]

@i0natan I tried to merge Master branch to korean-translate branch for update changes, but this operation cause conflict.
I think you renamed that file name and committed.
By the way, @XoDNr dose not respond, how do I to contribute? Just PR to this branch?
If dose, one solution is I manually merge this conflict.
And the other way is make new branch from current Master branch.

[goldbergyoni]

@hinco114 Yes, the way to go is PRing into the Korean branch, not master. Then once it's 100% ready PR the branch into master. Did you finish the entire translation work and want to merge into the master? on which files/branch do are you facing conflicts? I'll be glad to halp in resolving the conflicts

[hinco114]

@i0natan Not finished yet, I'm working on it as I have time, but I think it'll take a long time.
I merged master branch into korean-translate branch, and README.korean.md file conflicts with README.chinese.md file.
You can see that conflict when trying to merge or rebase master branch on korean-translate branch.

[goldbergyoni]

@hinco114 thanks for the update, I'll take a look at the conflict issue soon and share my thoughts. Does it block you now?

[hinco114]

Not really, I manually see the difference. But I will do the work faster if that problem is solved.

[goldbergyoni]

@hinco114 Fixed the merging issue, kindly pull latest korean-translation. Does it work for you now?