-
Notifications
You must be signed in to change notification settings - Fork 351
_content/doc: use mysql.NewConfig() instead of mysql.Config{} #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 99bbecf) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/website/+/582475. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/582475. |
This tutorial confuses users. |
Message from Inada Naoki: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/582475. |
Message from Zhen Li: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/582475. |
This PR (HEAD: 1031334) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/website/+/582475. Important tips:
|
Message from Inada Naoki: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/582475. |
Message from Sean Liao: Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/582475. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-04-12T12:25:44Z","revision":"efe435856c2e91438d5b206550696179c473b6b4"} Please don’t reply on this GitHub thread. Visit golang.org/cl/582475. |
Message from Sean Liao: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/582475. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/582475. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/582475. |
Message from Michael Pratt: Patch Set 4: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/582475. |
The zero values for `mysql.Config` is not good for default. See https://pkg.go.dev/github.com/go-sql-driver/mysql#Config > If a new Config is created instead of being parsed from a DSN string, the NewConfig function should be used, which sets default values. Change-Id: Ib09cce4a61f8a73571e45797edcd5ea37f0704ce GitHub-Last-Rev: 1031334 GitHub-Pull-Request: #281 Reviewed-on: https://go-review.googlesource.com/c/website/+/582475 Reviewed-by: Sean Liao <[email protected]> Reviewed-by: Michael Pratt <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Sean Liao <[email protected]>
This PR is being closed because golang.org/cl/582475 has been merged. |
The zero values for
mysql.Config
is not good for default.See https://pkg.go.dev/github.com/go-sql-driver/mysql#Config