exclude vendor dir from matching `...`

[omarkohl]

Go 1.9 changed the behavior of the Go tools such as "go test" and "go vet" to ignore the vendor directory when using triple dot (...) . See golang/go#19090

How about doing the same thing for golint? It makes sense to have different Go tools behave similarly.

[omarkohl]

It looks like it is addressed in #303 . Maybe this ticket could be considered as a proposal to make it the default behavior instead of an optional flag.

[nathany]

Making the default behaviour to ignore vendor would match Go 1.9, which is preferable in my mind.

Here are a few reasons for making golint ./... ignore the vendor directory by default.

1. Consistent with Go 1.9 behaviour for go test, go list, etc.
2. As per cmd/go: exclude vendor dir from matching ... go#19090, a solution that doesn't rely on Unix-specific tools (xargs) is beneficial for Windows users.
3. When there are an overwhelming number of lint issues from vendor, it's more likely that all lint issues will be ignored, rather than resolving lint issues within the project itself.

For example, in one project I'm working on, it looks like this:

❯ golint ./... | wc -l
    3987

Many of these lint issues may never be fixed, such as generated code for syscall.

vendor/golang.org/x/sys/unix/zsysnum_darwin_amd64.go:364:2: don't use ALL_CAPS in Go names; use CamelCase
...

If I break out some console-fu (e.g. StackOverflow) I can limit it to just the project:

❯ go list ./... | grep -v /vendor/ | xargs -L1 golint | wc -l
     183

But that isn't very user friendly, nor does it work on Windows.

/cc @dsymonds

[dlsniper]

Now that Go 1.9+ excludes vendor/ from ./... runs, maybe this can be reconsidered? Especially since go list ./... | xargs -L1 golint | wc -l does not exit with status 1 (unless further bash magic is applied). Thank you.

[yookoala]

Any updates on the consideration?

[bfosberry]

Bump

[jjrumi]

Not ideal but go list ./... | grep -v /vendor/ | xargs -L1 golint -set_exit_status does exit with error status