-
Notifications
You must be signed in to change notification settings - Fork 18k
ld/macho: add all missing load commands #25906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ld/macho: add all missing load commands #25906
Conversation
This PR (HEAD: 655e3f4) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/119115 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/119115. |
Message from Brad Fitzpatrick: Patch Set 1: [+iant] Misty, unless this fixes a currently-open bug for Go 1.11, we're generally pushing off all changes until August when the Go 1.12 tree opens. (https://github.com/golang/go/wiki/Go-Release-Cycle) If there's not an open bug, though, please open one with more details. We generally leave most discussion & details on GitHub and just have commits reference the issues. Thanks. Please don’t reply on this GitHub thread. Visit golang.org/cl/119115. |
Message from Misty De Méo: Patch Set 1:
Sorry for not opening a bug first! This does fix a specific bug I've encountered. I've filed one on GitHub: #25908 Please don’t reply on this GitHub thread. Visit golang.org/cl/119115. |
Message from Ian Lance Taylor: Patch Set 1: Run-TryBot+1 This is OK for 1.11. Please don’t reply on this GitHub thread. Visit golang.org/cl/119115. |
Message from Gobot Gobot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=952816ae Please don’t reply on this GitHub thread. Visit golang.org/cl/119115. |
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/119115. |
Message from Gobot Gobot: Patch Set 1: Build is still in progress... Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report. Please don’t reply on this GitHub thread. Visit golang.org/cl/119115. |
Message from Gobot Gobot: Patch Set 1: TryBot-Result-1 1 of 17 TryBots failed: Consult https://build.golang.org/ to see whether they are new failures. Please don’t reply on this GitHub thread. Visit golang.org/cl/119115. |
Message from Misty De Méo: Patch Set 2: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/119115. |
Message from Gerrit Bot: Uploaded patch set 3: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/119115. |
Message from Gerrit Bot: Uploaded patch set 4: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/119115. |
The ld/macho code currently understands a subset of the mach-o load commands. I've encountered one of these in the wild in a Go-produced binary, which tripped up the Go linker because its switch statement expects its list of load commands to be exhaustive; the rest I've added for the sake of completion. The ruby-macho library is a good non-Darwin header resource for these: https://github.com/homebrew/ruby-macho Fixes #25908 Change-Id: Ib54c065d27e87d8726a9870df05a2bae24828b98 GitHub-Last-Rev: 655e3f4 GitHub-Pull-Request: #25906 Reviewed-on: https://go-review.googlesource.com/119115 Reviewed-by: Ian Lance Taylor <[email protected]>
Message from Ian Lance Taylor: Patch Set 4: Code-Review+2 Thanks. Please don’t reply on this GitHub thread. Visit golang.org/cl/119115. |
This PR is being closed because golang.org/cl/119115 has been merged. |
The ld/macho code currently understands a subset of the mach-o load
commands. I've encountered one of these in the wild in a Go-produced
binary, which tripped up the Go linker because its switch statement
expects its list of load commands to be exhaustive; the rest I've
added for the sake of completion.
The ruby-macho library is a good non-Darwin header resource for these:
https://github.com/homebrew/ruby-macho
Fixes #25908