Skip to content

cmd/go: go test -json should only print JSON to stdout #54378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rsc opened this issue Aug 10, 2022 · 3 comments
Closed

cmd/go: go test -json should only print JSON to stdout #54378

rsc opened this issue Aug 10, 2022 · 3 comments
Labels
GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unplanned

Comments

@rsc
Copy link
Contributor

rsc commented Aug 10, 2022

Per discussion on #53893, go test -json should only print JSON to stdout.
We should ensure that's true.
@rsc rsc mentioned this issue Aug 10, 2022
Closed
@seankhliao
Copy link
Member

see also #35169

@thanm thanm added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 10, 2022
@rsc rsc mentioned this issue Aug 12, 2022
Open
@seankhliao seankhliao added this to the Unplanned milestone Aug 20, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/529120 mentions this issue: cmd/go: avoid writing non-JSON "build failed" errors from 'go test -json'

gopherbot pushed a commit that referenced this issue Sep 18, 2023
@gopherbot
cmd/go: avoid writing non-JSON "build failed" errors from 'go test -j…
5b123ae 
…son'

In 'go test -json' we expect stdout to contain only JSON events,
not unstructured text. Unstructured text should either go to stderr
or be wrapped in a JSON event.

(If we add structured build output in #62067, we can emit this output
as a build event instead of a test event.)

Fixes #35169.
For #54378.

Change-Id: Ibedd28e79b5adf8d6ae56165b9f0393b14ece9aa
Reviewed-on: https://go-review.googlesource.com/c/go/+/529120
Reviewed-by: Austin Clements <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
@abhipranay abhipranay mentioned this issue Nov 19, 2024
Closed
2 tasks
@seankhliao seankhliao added the GoCommand cmd/go label Feb 22, 2025
@matloob
Copy link
Contributor

matloob commented Mar 25, 2025 •
edited
Loading

I think this is now fixed. It looks like we write everything using the test2json converter for stdout or using the build json printer if gotestjsonbuildtext is not set.

@matloob matloob closed this as completed Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
5 participants
@rsc @gopherbot @seankhliao @thanm @matloob