-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Handle KaTeX warnings #13760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle KaTeX warnings #13760
Conversation
e8f2444
to
c523cac
Compare
c523cac
to
c7d1ac5
Compare
c7d1ac5
to
15c60f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. My only comment is that you can:
Please hold off on merging this for a bit. I found something related to the (unexpected) way that KaTeX handles the Note to self, again: disable See https://discourse.gohugo.io/t/newline-problem-with-transform-tomath/54833 for |
@jmooring Feel free to push to this PR (or if needed, just take my branch and create a new PR). |
When This is certainly solvable (e.g., caching a struct in a gob, caching JSON, etc.), but I'm not sure it's worth the effort. Unless there's a low-effort way to handle this, I think limiting the |
@jmooring have a look at my last commit. |
So they get repeated. See gohugoio#13735
b74c951
to
659a88f
Compare
This works really well. Ready to squash and merge when tests go green. Thanks. |
@jmooring I didn't know that the placment of the "co author" line mattered when squashing mattered, but now I know. |
@bep On the list of things that concern me, this is number 4374. |
Fix #13735