Regression: readDir now reads inside of theme directory

[stefanv]

There seems to be a change in the search base paths used by readDir between hugo v0.92.2-CDF6A0D6 and hugo v0.93.1-E9669FED.

When I compare the outputs of readDir ., I observe that with the latest version readDir returns results from both . and themes/my-theme, whereas the old version only read from ..

[bep]

Ironically this happened as a result of me adding some missing tests.

I do understand that the readDir is convenient, but you can I suspect that the functions in the resources namespace would be better, as what you get there (more specific, the Resource interface) fits into the rest of what we call "Hugo Pipes": You can publish it (.RelPermalink), process it (minify, fingerprint, build JavaScript bundles etc.) or you can inline the content .Content etc.:

https://gohugo.io/hugo-pipes/introduction/#find-resources-in-assets

[stefanv]

My take was that Resources would be the correct way to find files across theme and project, but that readDir would be very explicit in where it reads.

It's ironic, because looking at our readDir-using code (which led me to spot this change), it's clear that what we should be using resources instead, as you suggest.

[bep]

My take was that Resources would be the correct way to find files across theme and project,

That is one take, but any folder below /assets is only a composite if you make it so; if you put files in /assets/nothemesfileshereplease you should be safe.

[stefanv]

Thanks, I grasp the underlying model better now: the asset folder is special, in that it is a blend, and readDir respects its special nature.

[bep]

I'm going to fix this particular issue by reverting to the old behaviour; also see #9604