Add reveal button to EditorPropertyText for secret text #104742
+52
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO the button needlessly uses 2 icons. It could always show the open eye icon, pressed/released already look different. |
I would stay away from using only a colour to differentiate. Different icons are easier to see, especially for people who have limited eye sight. |
|
The button changes both icon and pressed state (the eye is colored, because it uses the pressed style). Maybe at least disable the toggle mode to make the button change only icon. Or maybe it's fine, idk. |
IceflowRE
force-pushed
the
editor_property_password
branch
from
c7042f9 to
7af4db5
Compare
|
Added button tooltip text and rebased. |
KoBeWi
reviewed
Apr 7, 2025
KoBeWi
reviewed
Apr 7, 2025
KoBeWi
reviewed
Apr 7, 2025
KoBeWi
reviewed
Apr 7, 2025
KoBeWi
reviewed
Apr 7, 2025
KoBeWi
reviewed
Apr 7, 2025
|
Will squash at the end. |
KoBeWi
reviewed
Apr 14, 2025
KoBeWi
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new button to the editor text property for properties marked as secrets. The button allows users to toggle between showing and hiding the secret text.
The tooltip is displayed only when the text is revealed to minimize the risk of accidentally exposing sensitive information. Previously, this was the only way to show the plain text, but is no longer necessary.