-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add documentation about OpenXR render models #11014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add documentation about OpenXR render models #11014
Conversation
Note: CI failures are related to upstream changes not being merged. |
2ff45dc
to
8b4ffc0
Compare
Just rebased this, but need to update the image with the latest rename we did. One sec. |
8b4ffc0
to
ecae4f5
Compare
Ok, image has been updated :) |
42f4e50
to
1987c8d
Compare
1987c8d
to
8aac142
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Should be good to merge once the demo project is merged.
8aac142
to
1b51729
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
.. raw:: html | ||
|
||
<div style="position: relative; padding-bottom: 56.25%; height: 0; overflow: hidden; max-width: 100%; height: auto;"> | ||
<iframe src="https://www.youtube.com/embed/_gNOd7wQ62M" frameborder="0" allowfullscreen style="position: absolute; top: 0; left: 0; width: 100%; height: 100%;"></iframe> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the nocookie
embed for better privacy:
<iframe src="https://www.youtube.com/embed/_gNOd7wQ62M" frameborder="0" allowfullscreen style="position: absolute; top: 0; left: 0; width: 100%; height: 100%;"></iframe> | |
<iframe src="https://www.youtube-nocookie.com/embed/_gNOd7wQ62M" frameborder="0" allowfullscreen style="position: absolute; top: 0; left: 0; width: 100%; height: 100%;"></iframe> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This falls beyond the scope of this documentation but an example | ||
implementation of this can be found in | ||
`our hand tracking demo <https://github.com/godotengine/godot-demo-projects/tree/master/xr/openxr_render_models>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BastiaanOlij does the hand tracking demo as it is now do what's described in this note? I'm not seeing any updates for that demo project for render models.
Documentation in support of godotengine/godot#107388,
Probably needs some tweaking after this PR is merged.