Relax base64 checking to match tartufo v2 #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow `=` to appear in the middle of strings (like we did in 2.x) instead of forcing it to appear only at the end (like base64 RFC requires). This more faithfully reproduces the old behavior and allows users -- such as ourselves -- to avoid updating signatures.
rbailey-godaddy
requested review from
irodelta,
sushantmimani and
emayuri-godaddy
and removed request for
a team
tarkatronic
approved these changes
Nov 17, 2021
mayuriesha
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help us get this pull request reviewed and merged quickly, please be sure to include the following items:
PR Type
What kind of change does this PR introduce?
Backward Compatibility
Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?
Issue Linking
What's new?
=to appear in the middle of strings (like we did in 2.x) instead of forcing it to appear only at the end (like base64 RFCrequires). This more faithfully reproduces the old behavior and allows users -- such as ourselves -- to avoid updating signatures.