Skip to content

Change toml parsing library to use tomlkit #231

Closed
@tarkatronic

Description

@tarkatronic

Currently tartufo uses the toml library for our parsing. This has worked great until now, but we are starting to reach the limits of the library. And unfortunately, it seems to be unmaintained currently. The last commit to the library was in October 2020, and I have encountered a bug (uiri/toml#270) which could impede our progress on future features.

tomlkit, on the other hand, is actively maintained by sdispater, the primary author/maintainer of the Poetry project. In fact, it is the TOML parser used for Poetry itself. So we can be assured that it will remain stable. In addition, we will be able to use this library in the future for writing back to the configuration file while preserving all pre-existing style, structure, etc!

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions